Changeset 20ebf9ee7c92f45369bd8786db43c057abab4266

Timestamp:

08/24/10 20:08:12 (3 years ago)

Author:

Nedko Arnaudov <nedko@…>

Children:

b2bd044cb85cd54a4a097d5642117987237c61ed

Parents:

27b57d818c10a7758e20bcf9e4304b25ced2d091

git-committer:

Nedko Arnaudov <nedko@arnaudov.name> / 2010-08-24T20:08:12Z+0300

Message:

Fix buffer overflow if pid_t is smaller than 64bits

Files:

• proxies/jack_proxy.c (modified) (1 diff)

proxies/jack_proxy.c

@@ -160 +160 @@
   pid_t * pid_ptr)
 {
-  return dbus_call(JACKDBUS_SERVICE_NAME, JACKDBUS_OBJECT_PATH, JACKDBUS_IFACE_PATCHBAY, "GetClientPID", "t", &client_id, "x", pid_ptr);
+  int64_t pid;
+
+  if (!dbus_call(JACKDBUS_SERVICE_NAME, JACKDBUS_OBJECT_PATH, JACKDBUS_IFACE_PATCHBAY, "GetClientPID", "t", &client_id, "x", &pid))
+  {
+    return false;
+  }
+
+  *pid_ptr = pid;
+  return true;
 }